Add description support for record type messages #62
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We at @ahrefs use have use messages descriptions quite often, and lack of description support was the blocker to migrate from object message type to record.
In this PR I propose to pass message descriptions to records with
[@intl.description ...]
annotation, ex:In this case, only the extractor aware of message description, and we don't have to deal with
{... description: None}
,{... description: Some("description")}
in the records, as we discussed beforecc @cknitt